conduit icon indicating copy to clipboard operation
conduit copied to clipboard

guards for hdf5 zlib mysteries

Open cyrush opened this issue 2 years ago • 0 comments

Hit a case where we wrote data that h5 stat tools show used the gzip filter, but the data was uncompressed, which casued some head scratching. The root cause was hdf5 was not configured with zlib correctly.

We suspect the writes succeeded b/c deflate filter (when set using H5Pset_deflate) makes gzip as optional.

We should add more explicit error checking.

This may mean we need to use H5Pset_filter, instead of the more convenient H5Pset_deflate

https://github.com/LLNL/conduit/blob/476e8cdbcff773709948d437edb42b74b8b7d487/src/libs/relay/conduit_relay_io_hdf5.cpp#L1367

related hdf5 docs:

https://docs.hdfgroup.org/hdf5/develop/group___o_c_p_l.html#title14

https://docs.hdfgroup.org/hdf5/develop/_f_i_l_t_e_r.html

cyrush avatar Jul 28 '23 17:07 cyrush