conduit
conduit copied to clipboard
Add pyramid and wedge support
Resolves #132
Adds support in the mesh blueprint for pyramids and wedges. Adds versions of braid that are comprised of pyramids and wedges.
Once merged I'll put up a PR in VisIt for the bp plugin.
The following still need to be done:
- [ ] Add to docs - crop pictures for basic wedges and pyramids + add code includes for docs
- [x] fix failing CI
- [x] add wedges and pyramids to everywhere that the other shape types are used that I haven't already
Suggestion I don't want to forget: Please add a Changelog entry.
Angle of the pictures looks good!
I would crop them down a bit so they fill more space on the docs page.
https://llnl-conduit--1023.org.readthedocs.build/en/1023/blueprint_mesh.html#pyramids
(compare pyramids with the hexs visual)
We also need the yaml output of the bluperint tree for wedges and pyramids.
And there is a small typo with the wedges entry ref in the table:
Angle of the pictures looks good!
I would crop them down a bit so they fill more space on the docs page.
https://llnl-conduit--1023.org.readthedocs.build/en/1023/blueprint_mesh.html#pyramids
(compare pyramids with the hexs visual)
We also need the yaml output of the bluperint tree for wedges and pyramids.
And there is a small typo with the wedges entry ref in the table:
Hi. I left this in draft b/c I knew I still needed to fix up these last few things w/ the docs. Nice catch on the wedges entry ref in the table. I'll get to these very very soon 😄
I was hoping to get these last few things done before you reviewed, my bad.
@JustinPrivitera yes, no worries, I had some time to review this morning so I wanted to see how things were going :-)
Thanks, @JustinPrivitera !
Looks good, thanks for working though all of this.
I'll merge once I figure out the strangeness with silo... the silo version of wedges looks very different from the blueprint version.