blt icon indicating copy to clipboard operation
blt copied to clipboard

Our var of CUDA_SEPARABLE_COMPILATION should be BLT_ CUDA_SEPARABLE_COMPILATION

Open cyrush opened this issue 6 years ago • 4 comments

CUDA_SEPARABLE_COMPILATION is the per target prop name, CMAKE_CUDA_SEPARABLE_COMPILATION is the global setting

but we are using: CUDA_SEPARABLE_COMPILATION in the blt macros

cyrush avatar Jun 20 '19 17:06 cyrush

On the subject of CUDA related variable, should there be a BLT_CUDA_ARCH variable that does the right thing? I have seen multiple ways to set this.

mclarsen avatar Jun 21 '19 14:06 mclarsen

Adding BLT_ to the cmake variables that BLT handles would help users understand what BLT is doing and what it is not.

mclarsen avatar Jun 21 '19 14:06 mclarsen

dejavu @mclarsen

cyrush avatar Apr 16 '21 17:04 cyrush

I agree that the naming is a little confusing. I recently noticed that we are passing -DCUDA_SEPARABLE_COMPILATION to our dependencies that use BLT, but it seems like we should be using -DCMAKE_CUDA_SEPARABLE_COMPILATION instead, though I'm not sure what BLT is actually expecting.

adayton1 avatar Feb 01 '22 17:02 adayton1