axom icon indicating copy to clipboard operation
axom copied to clipboard

Switch Map from int to IndexType for size

Open ksuarez1423 opened this issue 3 years ago • 3 comments

Summary

  • This PR is a feature.
  • It does the following (modify list as needed):
    • Modifies Axom Map to use IndexType instead of int for size and capacity tracking, thus allowing it to work with larger data.

ksuarez1423 avatar Aug 05 '21 19:08 ksuarez1423

Noticed a couple lingering errors in Azure. Fixing those before requesting review.

ksuarez1423 avatar Aug 05 '21 20:08 ksuarez1423

Looks like the issue is in the erase function around line 621: https://dev.azure.com/healy22/Status%20Check%20Testiing/_build/results?buildId=3757&view=logs&j=1e949c51-e916-5ae4-436c-7a23f916c6ae&t=3cb93f51-2f5f-529e-e892-962657e1e8f0

It's trying to use an atomic on incompatible 32-bit and 64-bit variables.

kennyweiss avatar Aug 06 '21 15:08 kennyweiss

Looks like the issue is in the erase function around line 621: https://dev.azure.com/healy22/Status%20Check%20Testiing/_build/results?buildId=3757&view=logs&j=1e949c51-e916-5ae4-436c-7a23f916c6ae&t=3cb93f51-2f5f-529e-e892-962657e1e8f0

It's trying to use an atomic on incompatible 32-bit and 64-bit variables.

I noticed, and had to log off yesterday before I could start casting -- I'll be doing that today.

ksuarez1423 avatar Aug 06 '21 15:08 ksuarez1423

This seems like it should be merged. Is there a reason not to update it and merge it?

white238 avatar Dec 04 '23 22:12 white238

This seems like it should be merged. Is there a reason not to update it and merge it?

I see no reason to leave out this PR. I'll make sure it gets merged.

agcapps avatar Dec 05 '23 16:12 agcapps