axom
axom copied to clipboard
Switch Map from int to IndexType for size
Summary
- This PR is a feature.
- It does the following (modify list as needed):
- Modifies Axom Map to use IndexType instead of int for size and capacity tracking, thus allowing it to work with larger data.
Noticed a couple lingering errors in Azure. Fixing those before requesting review.
Looks like the issue is in the erase
function around line 621: https://dev.azure.com/healy22/Status%20Check%20Testiing/_build/results?buildId=3757&view=logs&j=1e949c51-e916-5ae4-436c-7a23f916c6ae&t=3cb93f51-2f5f-529e-e892-962657e1e8f0
It's trying to use an atomic on incompatible 32-bit and 64-bit variables.
Looks like the issue is in the
erase
function around line 621: https://dev.azure.com/healy22/Status%20Check%20Testiing/_build/results?buildId=3757&view=logs&j=1e949c51-e916-5ae4-436c-7a23f916c6ae&t=3cb93f51-2f5f-529e-e892-962657e1e8f0It's trying to use an atomic on incompatible 32-bit and 64-bit variables.
I noticed, and had to log off yesterday before I could start casting -- I'll be doing that today.
This seems like it should be merged. Is there a reason not to update it and merge it?
This seems like it should be merged. Is there a reason not to update it and merge it?
I see no reason to leave out this PR. I'll make sure it gets merged.