UnifyFS icon indicating copy to clipboard operation
UnifyFS copied to clipboard

examples need non-UnifyCR baseline build

Open MichaelBrim opened this issue 7 years ago • 2 comments

Describe the problem you're observing

All the current examples include unifycr.h and require linking against either libunifycr or libunifycr_gotcha. This means there is no way to build a baseline version that does not use UnifyCR. The baseline version is necessary for verifying base functionality of the example and for performance comparisons against the UnifyCR-enabled versions.

For example, see PR #177 where I have modified the sysio_writeread.c example to have a pure POSIX target build. The other examples need something similar.

MichaelBrim avatar Oct 04 '18 14:10 MichaelBrim

@MichaelBrim, does #284 with your implementation of https://github.com/LLNL/UnifyCR/blob/984472b5a58f13f8b4008f5e7bb15b0e20b22547/examples/src/Makefile.am#L45 https://github.com/LLNL/UnifyCR/blob/984472b5a58f13f8b4008f5e7bb15b0e20b22547/examples/src/testutil.h#L38-L40 resolve this?

Or do other examples still need to be converted to this in order to be resolved?

CamStan avatar May 08 '19 20:05 CamStan

@CamStan That covers the new tests that use testutil.h, but we still have quite a few using testlib.h, including all the app_ ones

MichaelBrim avatar May 13 '19 13:05 MichaelBrim