Silo icon indicating copy to clipboard operation
Silo copied to clipboard

overhaul qt configuration logic

Open aowen87 opened this issue 6 years ago • 5 comments

AX_HAVE_QT, the m4 macro logic module Silo uses to configure Qt, is hugely outdated. We're lucky it even work on some systems. We need to replace this with some simple, configuration logic for Qt.

-----------------------REDMINE MIGRATION----------------------- This ticket was migrated from Redmine. As such, not all information was able to be captured in the transition. Below is a complete record of the original redmine ticket.

Ticket number: 1885 Status: New Project: VisIt Tracker: Bug Priority: Normal Subject: overhaul qt configuration logic Assigned to: - Category: - Target version: - Author: Mark Miller Start: 06/19/2014 Due date: % Done: 0% Estimated time: Created: 06/19/2014 08:44 pm Updated: 09/16/2014 02:25 pm Likelihood: 3 - Occasional Severity: 2 - Minor Irritation Found in version: 4.8 Impact: Expected Use: OS: All Support Group: Any Description: AX_HAVE_QT, the m4 macro logic module Silo uses to configure Qt, is hugely outdated. We're lucky it even work on some systems. We need to replace this with some simple, configuration logic for Qt.

Comments: I've overhauled AX_HAVE_QT, replacing the hacks and heuristics with clean logic to detect Qt 5 and later from $PATH and qmake. My revised version can be found at: https://github.com/alexhenrie/autoconf-archive/branchesI have also submitted the changes for inclusion in the GNU Autoconf Archive. No word yet: http://savannah.gnu.org/patch/?8486If you decide to move away from AX_HAVE_QT entirely, you will have to rewrite tools/silex/Makefile.am as a Qt pro file and invoke qmake during the configuration stage. The Autoconf Archive has accepted my revision of AX_HAVE_QT: http://git.savannah.gnu.org/cgit/autoconf-archive.git/commit/?id=a0ef75b4669fb9b173b1796daf3a72e2195fb1f2

aowen87 avatar Feb 26 '19 23:02 aowen87