Silo icon indicating copy to clipboard operation
Silo copied to clipboard

ndims argument in DBPutZonelist methods is incorrectly documented

Open aowen87 opened this issue 6 years ago • 0 comments

In DBPutZonelist and DBPutZonelist2, there is an ndims argument. In DBPutPHZonelist, there is no such argument but maybe there should be or should have been. At any rate, this argument is documented as the number of spatial dimensions in the cooresponding mesh. What? Why do we need to know about spatial dimensions when we're writing a zonelist? If anything, the most useful thing would be for it to be topological dimensions. On the other hand, other than the text in the Silo user's manual, I can't see anywhere where this numerical value is being interpreted except in DBAnnotateUcdmesh (and that method is really using as a topolgoical dimension anyways) and the Silo plugin in VisIt. And, I am convinced that it would be much better for this to be the topological dimension of the mesh. If so, however, there maybe some example codes and data files that need to get updated. Anywhere we are dealing with a ucd mesh of topologically two dimensional shapes (tris, quads and polygons) in 3 space.

-----------------------REDMINE MIGRATION----------------------- This ticket was migrated from Redmine. As such, not all information was able to be captured in the transition. Below is a complete record of the original redmine ticket.

Ticket number: 985 Status: New Project: VisIt Tracker: Bug Priority: Normal Subject: ndims argument in DBPutZonelist methods is incorrectly documented Assigned to: - Category: - Target version: - Author: Mark Miller Start: 02/27/2012 Due date: % Done: 0% Estimated time: Created: 02/27/2012 08:44 pm Updated: 02/27/2012 08:46 pm Likelihood: 3 - Occasional Severity: 3 - Major Irritation Found in version: 4.8 Impact: Expected Use: OS: All Support Group: Any Description: In DBPutZonelist and DBPutZonelist2, there is an ndims argument. In DBPutPHZonelist, there is no such argument but maybe there should be or should have been. At any rate, this argument is documented as the number of spatial dimensions in the cooresponding mesh. What? Why do we need to know about spatial dimensions when we're writing a zonelist? If anything, the most useful thing would be for it to be topological dimensions. On the other hand, other than the text in the Silo user's manual, I can't see anywhere where this numerical value is being interpreted except in DBAnnotateUcdmesh (and that method is really using as a topolgoical dimension anyways) and the Silo plugin in VisIt. And, I am convinced that it would be much better for this to be the topological dimension of the mesh. If so, however, there maybe some example codes and data files that need to get updated. Anywhere we are dealing with a ucd mesh of topologically two dimensional shapes (tris, quads and polygons) in 3 space.

Comments:

aowen87 avatar Feb 26 '19 22:02 aowen87