SAMRAI icon indicating copy to clipboard operation
SAMRAI copied to clipboard
verified publisher icon LLNL

Return shared pointers by reference instead of by value.

Open maikel opened this issue 7 years ago • 3 comments

This is a hopefully clean PR to issue #43.

maikel avatar Oct 19 '18 17:10 maikel

Nice :) I'm going to hold off on merging this one until #41 gets in, so we can run some of the tests. Thanks!

davidbeckingsale avatar Oct 19 '18 17:10 davidbeckingsale

That is a good idea since I haven't run any tests to check if something is breaking.

maikel avatar Oct 19 '18 17:10 maikel

We can test this locally too.

@nselliott - can you check this PR won't impact anything internal?

davidbeckingsale avatar Oct 19 '18 17:10 davidbeckingsale