RAJA icon indicating copy to clipboard operation
RAJA copied to clipboard

[WIP] Enhancements to Operators and Reduction Scaffolding

Open willkill07 opened this issue 5 years ago • 1 comments

Summary

  • This PR is an enhancement with some bug fixes and new features

It does the following:

  • Introduce BitXor reduction
  • operators::largest didn't have the correct overload for integral GPU types
  • op_adapter template simplified
  • static_assert checks introduced for:
    • integral types for bitwise operations
    • associative operators for reductions

To Do

  • [ ] testing
  • [ ] continue to evaluate current operator and reduction mechanisms

willkill07 avatar Aug 10 '20 01:08 willkill07

Codecov Report

Merging #868 into develop will decrease coverage by 0.041%. The diff coverage is 100.000%.

Impacted file tree graph

@@              Coverage Diff              @@
##           develop      #868       +/-   ##
=============================================
- Coverage   96.829%   96.788%   -0.042%     
=============================================
  Files           99        99               
  Lines         2555      2553        -2     
=============================================
- Hits          2474      2471        -3     
- Misses          81        82        +1     
Impacted Files Coverage Δ
include/RAJA/pattern/detail/reduce.hpp 100.000% <100.000%> (ø)
include/RAJA/util/Operators.hpp 100.000% <100.000%> (ø)
include/RAJA/policy/atomic_builtin.hpp 98.076% <0.000%> (-1.924%) :arrow_down:
include/RAJA/util/sort.hpp 95.402% <0.000%> (-0.053%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a81a530...a13f963. Read the comment docs.

codecov[bot] avatar Oct 20 '20 16:10 codecov[bot]