RAJA icon indicating copy to clipboard operation
RAJA copied to clipboard

Merge pull request #1 from LLNL/develop

Open rfhaque opened this issue 6 years ago • 6 comments

Merge pull request #549 from rfhaque/develop

rfhaque avatar Dec 11 '18 20:12 rfhaque

@rfhaque @trws - this should run the tests correctly now.

davidbeckingsale avatar Dec 11 '18 21:12 davidbeckingsale

I'm good with it assuming the tests pass after the merge back in from develop. Thanks again for putting this together @rfhaque, and helping us find a CI bug too. 😄

trws avatar Dec 12 '18 21:12 trws

Codecov Report

Merging #551 into develop will increase coverage by 0.002%. The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##           develop      #551       +/-   ##
=============================================
+ Coverage   98.623%   98.625%   +0.002%     
=============================================
  Files           64        64               
  Lines         1235      1237        +2     
=============================================
+ Hits          1218      1220        +2     
  Misses          17        17
Impacted Files Coverage Δ
include/RAJA/pattern/detail/reduce.hpp 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c562e55...09e592b. Read the comment docs.

codecov-io avatar Dec 12 '18 21:12 codecov-io

Can we please merge this PR?

rfhaque avatar Mar 13 '19 21:03 rfhaque

@rchen20 @davidbeckingsale @MrBurmark can this PR be closed now that we have support in RAJA for min/max loc reductions where loc can be a tuple of indices?

rhornung67 avatar Nov 12 '19 18:11 rhornung67

@rhornung67 Yes, this has been merged in another PR (branch since deleted).

rchen20 avatar Nov 12 '19 18:11 rchen20

Closing since the capability was merged in another PR.

rhornung67 avatar Jun 26 '24 20:06 rhornung67