Matrix Transpose Tutorial Cleanup

Open MrBurmark opened this issue 3 months ago • 7 comments

Summary

Fix the cuda and hip matrix tutorial. Fix spacing, add proper synchronization, map threads properly in teams implementation.

This PR is a bugfix
It does the following (modify list as needed):
- Fixes #1916

Sep 21 '25 17:09 MrBurmark

I think we also need to clean up the description of the problem to highlight the transpose of the indices as well as the CPU implementations to make it consistent with the gpu versions.

Sep 21 '25 17:09 artv3

Thanks for getting this started @MrBurmark. I took a follow up pass; but I think I could use a second set of eyes on the Kernel implementation. Would anyone in @LLNL/raja-core be able to take a look?

Sep 21 '25 22:09 artv3

@artv3 I think you've taken over this PR. There are come compilation issues that are causing the CI checks to fail. Can you get to them or should I try to find time to fix them? I assume we want this in the release.

Dec 08 '25 22:12 rhornung67

@artv3 I think you've taken over this PR. There are come compilation issues that are causing the CI checks to fail. Can you get to them or should I try to find time to fix them? I assume we want this in the release.

I can take a look, but I don't think this should hold up the release.

Dec 10 '25 15:12 artv3

@MrBurmark @artv3 I fixed the compilation errors in this, but the results are wrong.....

Dec 10 '25 21:12 rhornung67

I think we also have some inconsistent expression for the CPU RAJA::kernel examples. That is one thing that I needed to revisit.

Dec 10 '25 22:12 artv3

If I can find a few spare minutes, I will work on it. But, I can't promise I will get to it.

Dec 10 '25 23:12 rhornung67