RAJA icon indicating copy to clipboard operation
RAJA copied to clipboard
verified publisher icon LLNL

API and build changes for new SYCL compiler on corona.

Open rchen20 opened this issue 2 years ago • 3 comments

Summary

  • This PR is an update of the SYCL interface and compiler
  • It does the following:
    • Allows usage of an updated SYCL compiler on Corona (https://github.com/LLNL/RAJA/issues/1255)
    • Modifies SYCL build scripts
    • Changes some SYCL API calls
    • Changes Desul SYCL API calls

rchen20 avatar Dec 05 '23 22:12 rchen20

Hi @trws @rhornung67, in order to get this new SYCL compiler to work, I had to change some namespaces in this Desul file https://github.com/desul/desul/blob/master/atomics/include/desul/atomics/Adapt_SYCL.hpp. It appears that the latest version of that file is correct, but our RAJA version of Desul is out-of-date. Should I update Desul in RAJA to accommodate these changes?

rchen20 avatar Dec 05 '23 22:12 rchen20

@rchen20 there is a PR to update desul in RAJA, but it is on hold pending a BLT update https://github.com/LLNL/RAJA/pull/1563 The need for an update for a local compiler make the desul update more urgent. I will push on the BLT update.

rhornung67 avatar Dec 08 '23 21:12 rhornung67

@rhornung67 @homerdin These changes should be ready to go. Please review when you have a spare moment. Thanks!

rchen20 avatar Mar 08 '24 17:03 rchen20

@rchen20 are you good with this? I think it can be merged.

rhornung67 avatar Mar 14 '24 20:03 rhornung67

@rchen20 are you good with this? I think it can be merged.

Yes, I'll merge this. Thanks for trying it out.

rchen20 avatar Mar 14 '24 20:03 rchen20