RAJA icon indicating copy to clipboard operation
RAJA copied to clipboard

Adding Missing Associated Element/Index Types to Multiply ET Templates

Open braxtoncuneo opened this issue 2 years ago • 1 comments

This pull request adds the associated types element_type and index_type to TensorMultiply and TensorMultiplyAdd.

These types are necessary for the use of operations such as TensorDivide, which access them as part of their implementation.

The absence of these associated types resulted in compilation errors when attempting to use such operations with TensorMultiply/TensorMultiplyAdd as operands (https://github.com/LLNL/RAJA/issues/1303#issue-1317442775).

Given that this PR simply adds in associated types, it is unlikely to create any unforeseen side-effects. After all, if any code previously intended to use these types, it would have failed to compile.

braxtoncuneo avatar Aug 19 '22 23:08 braxtoncuneo

This latest version includes element_type and index_type declarations in BinaryOperator as well.

braxtoncuneo avatar Aug 23 '22 21:08 braxtoncuneo

Yes, let's cut it off here, this is the last of the most critical fixes. I'll add more testing and cleanup after the release in here https://github.com/LLNL/RAJA/pull/1289.

rchen20 avatar Oct 13 '22 19:10 rchen20

Does this have the camp update and warning fixes? Update: yes, let's merge and release.

MrBurmark avatar Oct 13 '22 20:10 MrBurmark

Does this have the camp update and warning fixes? Update: yes, let's merge and release.

It has everything in Camp up to October 7th. Is that enough?

rchen20 avatar Oct 13 '22 20:10 rchen20

Ya, that should be the latest commit to main.

MrBurmark avatar Oct 13 '22 20:10 MrBurmark

@rchen20 I restarted timed out Gitlab CI jobs and it is all green now. Do you want to merge?

rhornung67 avatar Oct 13 '22 21:10 rhornung67