GOTCHA
GOTCHA copied to clipboard
Interface-independent wrapping
An initial implementation of interface-independent wrapping, for feedback purposes. Use the new gotcha_sigfree_wrap() to wrap with pre/post wrappers that are independent of a function's signature, as discussed in #55.
Before merging this needs debugging prints, more tests, ppc64 support, and documentation.
This will also be complimented with a new gotcha query interface for listing libraries/symbols, which will allow one to do operations like wrap all functions exported from an arbitrary library.
Codecov Report
Merging #77 into develop will increase coverage by
0.67%
. The diff coverage is91%
.
@@ Coverage Diff @@
## develop #77 +/- ##
==========================================
+ Coverage 82.42% 83.1% +0.67%
==========================================
Files 10 11 +1
Lines 1064 1160 +96
==========================================
+ Hits 877 964 +87
- Misses 187 196 +9
Impacted Files | Coverage Δ | |
---|---|---|
src/tool.c | 58.33% <100%> (+0.78%) |
:arrow_up: |
src/gotcha.c | 90.49% <100%> (+0.54%) |
:arrow_up: |
src/thin.c | 89.02% <89.02%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0ec062b...89a05a0. Read the comment docs.
Added ppc64le support and tests, but still need documentation on new interfaces
This should be ready for review
Cool. It'll probably be a couple of weeks before I can really give it a look, but thanks for putting it together
@mplegendre , last I looked I thought I had approved this? Oops. I'll approve it in a review now