CHAI icon indicating copy to clipboard operation
CHAI copied to clipboard

CHAI_LOG only active with CHAI_DEBUG regardless of RM being enabled

Open robinson96 opened this issue 4 years ago • 3 comments

Not sure if this was intentional or not, but CHAI_LOG has been incurring overhead for non debug builds. This has shown up in some of CARE's stress testing kernel launch overhead (can double the cost of a kernel capture and launch). This PR changes CHAI_LOG to only do something when CHAI_DEBUG is defined.

robinson96 avatar Nov 02 '20 18:11 robinson96

LGTM

davidbeckingsale avatar Nov 02 '20 19:11 davidbeckingsale

I would rather this be a runtime option, because otherwise people will compile with it turned off and it makes it difficult to help debug issues.

Can we maybe remove the messages you were seeing cause a lot of overhead?

davidbeckingsale avatar Nov 02 '20 19:11 davidbeckingsale

@adayton1 I think your PR #195 is similar to this, and I prefer the fine-grained approach here.

davidbeckingsale avatar Sep 01 '21 23:09 davidbeckingsale