Lars Kreutzer

Results 36 comments of Lars Kreutzer

https://github.com/LKreutzer/magma/actions/runs/2823690635 Fully successful - Runs all relevant configs - Has `set -euo pipefail` - Only relevant targets are used in each config - Starlark format and python import checks are...

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks

Nice read on how to use matrix workflows if the job should be required: https://brunoscheufler.com/blog/2022-04-09-the-required-github-status-check-that-wasnt

- [x] If the build step is skipped it will still return green at the end: - Test run https://github.com/LKreutzer/magma/actions/runs/2826379794 - Test PR on fork: https://github.com/LKreutzer/magma/pull/1 - [x] If one...

Jobs that need to be set to **required**: - [x] **NOT** the overall workflow - [x] `c_cpp_file_check` / `Check if there are non-bazelified c or c++ files` (already true ?)...

Ping, are you doing this already on another ticket? @alexzurbonsen @sebathomas @wolfseb @MoritzThomasHuebner

> @LKreutzer Just FYI, I think the ready2merge tag should only be added if the PR has been approved already, while I think this one is still waiting for someone...

> Idea for merge strategy: remove required settings for the bazel workflow completely, rerun workflows here, merge, re-enable after a couple of days (when rebases are expected) @LKreutzer what do...

- [x] Check that the service is covered by the current bazel build in the workflow - This was not the case, added a union to feg. - `bazel query...

- Filled the cache key: `magma-dev-vm` - Run: https://github.com/LKreutzer/magma/actions/runs/2832728919 - Tests are failing (unclear what is going on) - First error: - ![Screenshot from 2022-08-10 16-44-28](https://user-images.githubusercontent.com/34488763/183931772-7807c923-23fb-444b-b193-8f8a2aacbbdd.png) - Build was successful...