laravel-uptime-monitor-api icon indicating copy to clipboard operation
laravel-uptime-monitor-api copied to clipboard

Published 20 hours ago • verified publisher icon LKaemmerling

Will support for version 3 of the uptime monitor be made available?

Open duffner opened this issue 7 years ago • 7 comments
trafficstars

duffner avatar Mar 14 '18 02:03 duffner

Since i doesn't use the package anymore i have no testing environment for this. But PRs are welcome!

LKaemmerling avatar Mar 14 '18 05:03 LKaemmerling

my fork adds compatibility with v3 as well as pulling in both current PRs and improved exception handling I got from another fork

vesper8 avatar Apr 13 '19 13:04 vesper8

@vesper8 if you want you could contribute this to this repo and get write access to it :)

LKaemmerling avatar Apr 13 '19 14:04 LKaemmerling

I don't know @LKaemmerling .. I've never maintained a public repo before.. totally unfamiliar with CI and how that works.. releases, tagging, and wouldn't even be sure whether these upgrades should go under a 3.0 version or stay on 2.0.. or how to even change that

I could submit a PR with all the changes and you could approve it? That's all it needs and it'll be good for another year or more

vesper8 avatar Apr 13 '19 14:04 vesper8

Yeah, this would be possible. If you want, i could show you everything which is needed for this :) OpenSource means teaching too :D

LKaemmerling avatar Apr 13 '19 15:04 LKaemmerling

I appreciate the generous offer. Even though I too have way too much on my plate at the moment, I'm inclined to agree, assuming it doesn't take too much of your time. How would we proceed?

vesper8 avatar Apr 13 '19 20:04 vesper8

First of all you should create a PR with your changes :) I will review it then and add my comments about style, tests and so on there.

LKaemmerling avatar Apr 15 '19 05:04 LKaemmerling