Lukas Kämmerling

Results 69 comments of Lukas Kämmerling

I personally don't think we should start adding things that implement the client/sdk because it will be unfair for others and in the end, the list might be really big....

Hey @pmcgoverncw, good idea! If you want (and have time) feel free to submit a MR :)

Hey @EdgarSedov, good point! I already looked a bit into the code and I don't think this is easy solvable. The "problem" is that we only set the value/metric when...

My idea would be to add a timestamp + used memory size at the construction of the RegistryCollector and before we render (at https://github.com/PromPHP/prometheus_client_php/blob/f151e0b97e0fa59aee553be8e25b84b52fc4172d/src/Prometheus/CollectorRegistry.php#L69) the metrics again save the timestamp...

Hey @hrodic, good idea, on a first (not deep) look it looks like this is something we can consider doing. Would you like to submit an MR :)? Otherwise, I...

Hey @EdgarSedov, looks okay for me, but can you also please add tests?

Hey @timmipetit, can you try to downgrade to v2.6.0 just to make sure it is really related to the script? How many metrics do you expose? Might it be that...

Hello together, i just released v2.6.2 with the revert of the given MR.

Hey @mp3000mp, sure :) Feel free to work on a MR and i will look over it.

Hey, I guess we should follow the same way as the go client. @mp3000mp do you want to prepare the change :)? I guess we can do it as a...