vndr icon indicating copy to clipboard operation
vndr copied to clipboard

vndr init doesn't get some of the dependencies

Open DmitriyMV opened this issue 8 years ago • 7 comments

For example - it will get the github.com/mattn/go-colorable and github.com/mattn/go-isatty for github.com/fatih/color, but will not get the transitive dependency of golang.org/x/sys/unix from https://github.com/mattn/go-isatty/blob/master/isatty_solaris.go#L7

DmitriyMV avatar Mar 10 '17 19:03 DmitriyMV

@DmitriyMV is this with vndr init? Just vndr isn't supposed to download anything, not in vendor.conf because otherwise, you could end with some weird appengine code.

LK4D4 avatar Mar 13 '17 21:03 LK4D4

Yes - with vndr init

DmitriyMV avatar Mar 14 '17 11:03 DmitriyMV

@DmitriyMV I suppose it might be windows problem :/ It works correctly for me. Can you try again to confirm? Then I'll try to get windows box to test.

LK4D4 avatar Apr 06 '17 04:04 LK4D4

I tried it right now on my work Linux machine - still the same.

Code:

package main

import (
	"github.com/mattn/go-colorable"
)

func main() {
	colorable.NewColorableStdout()
}

go data:

dmitriy@MD-PC ~> go version
go version go1.8.1 linux/amd64

dmitriy@MD-PC ~> go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/dmitriy/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build870112013=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

Folder structure:

.
├── main.go
├── vendor
│   └── github.com
│       └── mattn
│           ├── go-colorable
│           │   ├── colorable_appengine.go
│           │   ├── colorable_others.go
│           │   ├── colorable_windows.go
│           │   ├── LICENSE
│           │   ├── noncolorable.go
│           │   └── README.md
│           └── go-isatty
│               ├── doc.go
│               ├── isatty_appengine.go
│               ├── isatty_bsd.go
│               ├── isatty_linux.go
│               ├── isatty_others.go
│               ├── isatty_solaris.go
│               ├── isatty_windows.go
│               ├── LICENSE
│               └── README.md
└── vendor.conf

5 directories, 17 files

vendor.conf

github.com/mattn/go-colorable ded68f7a9561c023e790de24279db7ebf473ea80
github.com/mattn/go-isatty fc9e8d8ef48496124e79ae0df75490096eccf6fe

No golang.org/x/sys/unix in my vendor =(

DmitriyMV avatar Apr 11 '17 10:04 DmitriyMV

@DmitriyMV I don't understand. Did you do vndr init to get that vendor.conf? There can't be package in vendor if it isn't listed in vendor.conf.

LK4D4 avatar Apr 11 '17 15:04 LK4D4

Yes - I did vndr init to get this vendor.conf and vendor directory.

DmitriyMV avatar Apr 11 '17 15:04 DmitriyMV

This happens when package is found in $GOPATH. I'll try to fix that this week.

LK4D4 avatar Apr 11 '17 15:04 LK4D4