js-sdk icon indicating copy to clipboard operation
js-sdk copied to clipboard

Fix/execute with retry wrapper exec

Open joshLong145 opened this issue 9 months ago • 0 comments

Description

Removes executeWithRetry as we no longer need to retry operations due to network stability fixes. We now will only retry operations which are critical to the standup of the sdk. The included node endpoints which are eligible for retry at this time are:

  • /handshake

Status codes we will retry on:

  • 408
  • 500
  • 502
  • 503
  • 504

Introduces a new package fetch-retry which now handles retry logic for single requests. As we no longer need to group requests and retry as single network operation.

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Tested with local testing to force endpoint failure to observe retry.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

joshLong145 avatar May 24 '24 19:05 joshLong145