js-sdk icon indicating copy to clipboard operation
js-sdk copied to clipboard

Feature/lit 3164 investigate issue in react native with global var usage

Open joshLong145 opened this issue 9 months ago • 0 comments

Description

  • Removes node-fetch and cross-fetch from packages to no longer attempt to configure a fetch method on global object if none is available.
  • Removes usage of global in favor of globalThis

PR needs a corresponding docs update to outline how one may polyfill fetch if their environment does not provide it.

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update

How Has This Been Tested?

Tested current functionality works as expected within NodeJS without the implicit polyfilling.

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

joshLong145 avatar May 20 '24 19:05 joshLong145