js-sdk icon indicating copy to clipboard operation
js-sdk copied to clipboard

fix: change call to 'checkAndSignAuthMessage' in eth provider authenticate

Open joshLong145 opened this issue 10 months ago • 0 comments

Description

  • Refactors access to the latestBlockHash to use getLatestBlockhash which will force re-syncing if needed.
  • wraps a call to checkAndSignAuthMessage for use only within a browser context as currently the implementation will assume access to a global object for wallet interactions typically only found within browser plugin models.

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Ran current e2e testing and confirmed signatures from a signer with a signMessage implementation

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

joshLong145 avatar Apr 19 '24 22:04 joshLong145