candy-shop icon indicating copy to clipboard operation
candy-shop copied to clipboard

feat: EVM marketplace

Open vanminh1701 opened this issue 2 years ago • 2 comments

vanminh1701 avatar Oct 14 '22 06:10 vanminh1701

  1. services folder: contain factory class for picking right NFT function for each chain For multichain feature, transaction functions about buy, sell, cancel NFT need to be applied follow ETH or SOL CandyShop, so we need to pass CandyShop instance prop to component using it and I use factory class to pick the right function for each blockchain network
  2. Mustnt pass candyShop instance to Modal components and all nested inside them Modal component: SellModal, CancelModal, BuyModal, ... nested: Price, Card, NftStats
  3. CandyShop properties are using for render UI need to declare in BaseShop class to prenvent check condition in UI part
  4. EthCandyshop needs to fetch API shop owner to get candyShopAddress, so I expose API getEthCandyShop to handle it: fetch shop detail then create new EthCandyShop instance and return to user
  5. Add some common interfaces: ConfigPrice, ShopProps,

vanminh1701 avatar Oct 14 '22 07:10 vanminh1701

The index.ts should be the index for exporting of the folder, should not put logics in it. Let's make following structure and rename under conveyor/eth/ .

  • api/index.ts -> api.ts
  • blockchain/index.ts -> blockchain.ts
  • seaport/index.ts -> seaport.ts
  • index.ts -> convey.ts
  • types/asset/index.ts -> types/asset.type.ts
  • types/blockchain/index.ts -> types/blockchain.type.ts
  • types/network/index.ts -> types/network.type.ts
  • types/order/index.ts -> types/order.type.ts
  • types/shop/index.ts -> types/shop.type.ts

haVincy avatar Oct 16 '22 02:10 haVincy