lips icon indicating copy to clipboard operation
lips copied to clipboard

Reference filter bar should be sticky

Open jcubic opened this issue 1 year ago • 9 comments

If you search in Algolia and land on the reference page, you can't use the filter. It should be always visible (use position: sticky).

https://lips.js.org/reference#define

Also, maybe it would be nice to improve the design of the search bar.

jcubic avatar May 20 '24 18:05 jcubic

Hi, I would like to work on this issue. Could you please assign it to me?

vidhihattar avatar May 21 '24 04:05 vidhihattar

Go ahead, but note that Open Source project, don't use assignments on GitHub. Especially for non-core contributors.

jcubic avatar May 21 '24 07:05 jcubic

Thank you for letting me know. I saw other people asking to be assigned the issues in OS projects so I thought that's how it is supposed to be.

On Tue, May 21, 2024 at 1:01 PM Jakub T. Jankiewicz < @.***> wrote:

Open Source project, don't use assignments on GitHub. Especially for non-core contributors.

— Reply to this email directly, view it on GitHub https://github.com/LIPS-scheme/lips/issues/364#issuecomment-2121946382, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUILXCKMYIKAH7TED4G36Y3ZDLZ4TAVCNFSM6AAAAABIAEN7P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRRHE2DMMZYGI . You are receiving this because you commented.Message ID: @.***>

vidhihattar avatar May 21 '24 08:05 vidhihattar

I have no idea why people keep asking this.

jcubic avatar May 21 '24 08:05 jcubic

Sorry to bother you but I wanted to ask if this is an error on my end? please see the image attached. When I run the make command it says that there is an issue in the makefile. I searched online and it said that I needed to make changes in the makefile so I wanted to confirm if this is an issue on my system.

On Tue, May 21, 2024 at 1:51 PM Jakub T. Jankiewicz < @.***> wrote:

I have no idea why people keep asking this.

— Reply to this email directly, view it on GitHub https://github.com/LIPS-scheme/lips/issues/364#issuecomment-2122046250, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUILXCNOZC3RJDEMU4DWZMDZDL7W3AVCNFSM6AAAAABIAEN7P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRSGA2DMMRVGA . You are receiving this because you commented.Message ID: @.***>

vidhihattar avatar May 21 '24 09:05 vidhihattar

No, sorry the Makefile is only for source code. I need to update the Contribution guide for the documentation that was recently created. To work on the docs locally you need:

cd docs
npm install
npm run start

jcubic avatar May 21 '24 10:05 jcubic

Also note that if you reply to an issue with an email, attachments are removed. To add an image you need to use the GitHub interface.

jcubic avatar May 21 '24 10:05 jcubic

And when you will create a branch use master, so the changes will be instantly visible on the website.

jcubic avatar May 21 '24 10:05 jcubic

Got it, thanks for the help!

On Tue, May 21, 2024 at 4:29 PM Jakub T. Jankiewicz < @.***> wrote:

And when you will create a branch use master, so the changes will be instantly visible on the website.

— Reply to this email directly, view it on GitHub https://github.com/LIPS-scheme/lips/issues/364#issuecomment-2122368271, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUILXCLRZCF5I7YDJSMUPYDZDMSKBAVCNFSM6AAAAABIAEN7P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRSGM3DQMRXGE . You are receiving this because you commented.Message ID: @.***>

vidhihattar avatar May 21 '24 11:05 vidhihattar