lips icon indicating copy to clipboard operation
lips copied to clipboard

Various typos

Open WarpedWartWars opened this issue 4 years ago • 3 comments

For example:

  • the help for * has "Multiplicate" instead of "Multiply"
  • at least two functions have "Function return" instead of "This function returns" or something etc. I'm thinking of making a pull request with all of these fixed, but I don't know where they all are.

Edit: they're in lips.js.

WarpedWartWars avatar Nov 18 '21 20:11 WarpedWartWars

Yes, there are a lot of errors. I'm not a native English speaker and make a lot of mistakes. There is an issue to run Grammarly over every docstrigs #195. Some of them are in src/lips.js and some of them in lib/*.scm files.

jcubic avatar Nov 18 '21 21:11 jcubic

Also, I recently removed the UMD code from src/lips.js so the indentation of the whole code changed and all docstrings have the wrong indent, which also needs to be fixed. I've fixed it in the es-modules branch but the way LIPS is constructed doesn't allow to split the file into modules.

jcubic avatar Nov 18 '21 21:11 jcubic

Ok. I've made a pull request here to fix them. However, it's a draft pull request because I haven't made all of the fixes yet.

WarpedWartWars avatar Nov 18 '21 21:11 WarpedWartWars

Marking this as duplicate because there is a new issue that also explains how to contribute for newcomers.

jcubic avatar Oct 01 '22 15:10 jcubic