SameBoy icon indicating copy to clipboard operation
SameBoy copied to clipboard

noise channel emulation is kinda off

Open djmaximum17 opened this issue 4 years ago • 3 comments

lower frequency registers of the noise channel seem to be incorrect. VBA-M and other GB emulators get it right.

https://user-images.githubusercontent.com/61179162/106647240-4c7f4700-6554-11eb-9dfb-bd4de24a2a6b.mov

https://user-images.githubusercontent.com/61179162/106647278-57d27280-6554-11eb-8b80-98e1aeecdfea.mov

djmaximum17 avatar Feb 02 '21 18:02 djmaximum17

It appears that @djmaximum17 uses a CGB-A for comparison.

jkotlinski avatar Feb 11 '21 09:02 jkotlinski

I need a test ROM to test it on various hardware revisions and the latest master.

LIJI32 avatar Feb 25 '21 15:02 LIJI32

I've also noticed a tiny bit of extra popping while playing on the Retroarch core version. It seems to pop whenever the noise channel's note is halted.

Nimta avatar Apr 26 '21 22:04 Nimta