gnome-shell-extension-simple-system-monitor
gnome-shell-extension-simple-system-monitor copied to clipboard
Resolve the feedback received during the submission of v15 to GNOME extensions
-
lookupByUUID()
is a bad practice (line 323 extension.js). You can sendthis
from the entry point to the class needing it when it's possible (dependency injection). -
Use
export class
instead ofexport var
. -
Make it local to
fillPreferencesWindow()
(line 73 prefs.js). -
Don't store any instance in global scope since that cannot get garbage collected after window close (line 70 prefs.js).
-
Don't use the same property name for the timeout ids (line 410 and 535 extension.js).
-
Please use
TextDecoder
instead ofbyteArray
(line 34 extension.js): https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder