Scatterer icon indicating copy to clipboard operation
Scatterer copied to clipboard

Sky renders incorrectly in KerbalVR apparently due to ocean renderer commandbuffer

Open JonnyOThan opened this issue 1 year ago • 3 comments

When using scatterer 0.0878 or 0.0880 with KerbalVR, the sky generally will appear black - unless you look up. There is a hard clipping line where the sky is drawn normally. I think I've tracked this down to some kind of problem with the ocean meshrenderer commandbuffer. The line that separates "good" from "bad" corresponds to where this command buffer draws into the depth/stencil buffer.

image

image

https://drive.google.com/file/d/1sm1NxsKQBWyqwqBKXCNrEf9JjYBC9QBl/view?usp=sharing

JonnyOThan avatar Nov 23 '24 02:11 JonnyOThan

Ooh, renderdoc had flagged some errors here and 2 of them are actually on the draw calls involved in the issue here: image

JonnyOThan avatar Nov 23 '24 02:11 JonnyOThan

I think I have a fix for this, PR incoming shortly

JonnyOThan avatar Nov 23 '24 04:11 JonnyOThan

Changes sound good, thanks a lot. I'm in the middle of working on some other stuff for scatterer and it may be a while before I merge and release this, so feel free to distribute fixed dlls with kerbalVR in the meantime.

LGhassen avatar Nov 23 '24 04:11 LGhassen