komorebi icon indicating copy to clipboard operation
komorebi copied to clipboard

[BUG]: double monocle a lone window on a desktop results in it having no container

Open raggi opened this issue 1 year ago • 1 comments

Describe the bug

If you toggle monocle twice on a window that is the sole window in the sole workspace on a monitor, the toggle on/off works (after the fix for the panic described in #757), but the monitor is left with no workspace, and the window is left orphaned, so it can no longer be focused by commands.

To Reproduce Steps to reproduce the behavior:

  1. Open a single window on a single monitor
  2. Toggle monocle twice
  3. Focus a window on a second monitor
  4. Observe inability to focus original window, as there is no container in that direction
  5. Focus the orphaned window, observe inability to focus windows in other directions due to "no container"

Expected behavior The window should have a container after it is restored from monocle.

Additional context There is some kind of logic bug that would cause a panic, that is described in #757, that will be fixed independently - but may now further hide the bug.

raggi avatar Apr 14 '24 04:04 raggi

@RaptDept this is technically "fixed" here, but the fix could be improved:

https://github.com/LGUG2Z/komorebi/commit/6fce630be537bbeeb50ad38287843a5d12f60d08

LGUG2Z avatar Apr 21 '24 19:04 LGUG2Z