komorebi icon indicating copy to clipboard operation
komorebi copied to clipboard

feat(wm): adds Komorebic taskbar visibility controls

Open LegitCamper opened this issue 10 months ago • 6 comments

Adds support for two Komorebic commands ToggleTaskbarVisibility and ShowTaskbar which can either be true or false. This prevents the need to use alternative tools, and will provide access for ahk scripts to control taskbar visibility.

This is my first real PR so if there is anything weird let me know.

LegitCamper avatar Apr 06 '24 22:04 LegitCamper

Thank you for this contribution, it looks very cool! I'll try this out during the week and flag it to the testers on Discord. If all is good hopefully we can ship this with v0.1.24 🚀

LGUG2Z avatar Apr 07 '24 14:04 LGUG2Z

We'll need to update the application exit and stop handlers to restore the taskbar (any change to the system that komorebi makes should be reverted when the process stops)

LGUG2Z avatar Apr 07 '24 15:04 LGUG2Z

2024-04-07T22:28:52.335619Z ERROR komorebi::process_command: The operation completed successfully. (os error 0)
2024-04-07T22:28:59.118943Z ERROR komorebi::process_command: The operation completed successfully. (os error 0)
2024-04-07T22:29:02.876010Z ERROR komorebi::process_command: The operation completed successfully. (os error 0)
2024-04-07T22:29:04.672027Z ERROR komorebi::process_command: The operation completed successfully. (os error 0)

This is what I'm getting when running either of the new commands locally from this build 🤔

LGUG2Z avatar Apr 07 '24 22:04 LGUG2Z

Would it be worth adding a config option for this? When using Komorebi, I'd like the taskbar to always be hidden, and the only way I see to do that now is to add another command to my startup script to toggle it off.

Insprill avatar Apr 18 '24 15:04 Insprill

I'll try building and running this branch again when I get some time; last time I tried it I didn't have any luck. Once the implementation is sound we can definitely look at adding both komorebic and static config options for manipulating the behaviour.

LGUG2Z avatar Apr 18 '24 15:04 LGUG2Z

I'm testing this PR now, and it appears to be working fine on my primary monitor, but the taskbar doesn't get hidden on my other two monitors. I don't know what's up with that, as changing the scale of my secondary monitors causes the taskbar to deform like it's ignoring events as if it's supposed to be hidden. However, it still gets updated and is interactable. Reenabling it with komorebic will fix the deformation.

Insprill avatar Apr 18 '24 15:04 Insprill