komorebi icon indicating copy to clipboard operation
komorebi copied to clipboard

Animations Request

Open jaden-falls opened this issue 1 year ago β€’ 9 comments

Is there any way for komorebi to manipulate animations while moving the windows like picom and hyprland?

jaden-falls avatar Jun 19 '23 19:06 jaden-falls

This isn't something that I personally have any interest in working on, but I will leave the issue open in the hopes that if anyone really wants this enough, they will built it πŸ‘Œ

LGUG2Z avatar Jun 19 '23 23:06 LGUG2Z

Hello there! I'm currently working on animation. Here demo (sorry have to split video for 2 parts because of the limitation of github). Currently have 2 major problem with that as you can see in my demo.

  1. Border window doesn't update properly.
  2. Goggle chrome window brokes if you will move it during animation in progress

Part1

https://github.com/LGUG2Z/komorebi/assets/74871489/8955424f-1178-4be2-a1a9-f37bd35bd112

Part2

https://github.com/LGUG2Z/komorebi/assets/74871489/4fb249b1-6c37-4c74-8d93-07748a7bc289

I've implemented commands to enable/disable animation, set the duration of animation in ms, set ease function which will be applied to animation. I didn't publish my fork yet. Trying to fix Google chrome window πŸ™‚

UPD

I'm new to rust and low level programming. Usually write some server-side typescript. So it's may took long time to finish my implementation

thearturca avatar Sep 29 '23 14:09 thearturca

@thearturca This is so amazing! I can't wait to try this out! Please give me an @ ping when your fork is published and I'll see if I can help with the border window updates 🀞

LGUG2Z avatar Sep 29 '23 16:09 LGUG2Z

@LGUG2Z I published my fork. Didn't solve issue with Google Chrome window. Maybe you have some thought about it. My explanations in last commit and in code via comments.

https://github.com/thearturca/komorebi/tree/animate-window-move

thearturca avatar Oct 05 '23 17:10 thearturca

@thearturca I made some good progress on fixing the border issues today; can you open a PR from your branch to the main repo so that I can push some changes for you to try out?

LGUG2Z avatar Nov 25 '23 01:11 LGUG2Z

I was able to add a new origin to your fork and push it back here @thearturca

https://github.com/LGUG2Z/komorebi/tree/animate-window-move

I've rebased with the latest release, added a new commit on top which addresses some lints from the output of cargo clippy and also added my fix for the border updates πŸš€

LGUG2Z avatar Nov 25 '23 02:11 LGUG2Z

I was able to add a new origin to your fork and push it back here @thearturca

https://github.com/LGUG2Z/komorebi/tree/animate-window-move

I've rebased with the latest release, added a new commit on top which addresses some lints from the output of cargo clippy and also added my fix for the border updates πŸš€

Wow amazing work! Since you add new origin, do I need to make a PR?

thearturca avatar Nov 25 '23 16:11 thearturca

Since you add new origin, do I need to make a PR?

Oops I forgot to open the PR; I'll do that now so that we can leave comments on code changes there!

LGUG2Z avatar Nov 25 '23 17:11 LGUG2Z

status report gif This sounds interesting! Any status report?

renhiyama avatar Apr 27 '24 20:04 renhiyama

@thearturca #921 sir this way

FlyinCow avatar Jul 24 '24 05:07 FlyinCow

meanwhile, any plans on workspace animation?

FlyinCow avatar Jul 24 '24 05:07 FlyinCow