komorebi icon indicating copy to clipboard operation
komorebi copied to clipboard

[BUG]: Komorebi Bar does not understand multiple batteries

Open MsiDeer opened this issue 8 months ago • 4 comments

Summary

Komorebi Bar only reports the remaining capacity of one battery in my system One battery at 10% renaming and the other at 90% and Komorebi Bar only shows 10%

Version Information

WIn 11 Pro Version: 10.0.26100 N/A Build 26100

komorebic 0.1.36 commit_hash: 8ef1bcf2 build_time: 2025-04-13 03:10:57 +00:00 build_env:rustc 1.86.0 (05f9846f8 2025-03-31),stable-x86_64-pc-windows-msvc

Komorebi Configuration

Default

Hotkey Configuration

Default

Output of komorebic check

No KOMOREBI_CONFIG_HOME detected, defaulting C:\Users\Msi

Looking for configuration files in C:\Users\Msi

Found komorebi.json; this file can be passed to the start command with the --config flag

Found C:\Users\Msi.config\whkdrc; key binding will be loaded from here when whkd is started, and you can start it automatically using the --whkd flag

MsiDeer avatar Apr 29 '25 02:04 MsiDeer

TIL you can have multiple batteries - will check if the underlying library understands this and returns an iterator or is just popping the first

LGUG2Z avatar Apr 29 '25 04:04 LGUG2Z

how does windows report on multiple batteries?

CtByte avatar Apr 29 '25 07:04 CtByte

In the normal windows taskbar it shows the combined percentage of both batteries

For example one is full and the other is at 10% the taskbar would say that 60% is remaining

In that same example, if I went into settings it would show the combined percentage and then under it the individual percentages

60% Battery Remaining Battery 1: 99% and In Use Battery 2: 10%

if Batt. 2 had more charge it would also report as In Use alongside 1

When I get home I'll take a video showing both my problems better

MsiDeer avatar Apr 29 '25 12:04 MsiDeer

https://github.com/LGUG2Z/komorebi/blob/3c4ccd2504e49944768734e5b21cfe750174a2a9/komorebi-bar/src/widgets/battery.rs#L90-L126

Looks like we are just popping the first - this should be fixable

LGUG2Z avatar Apr 29 '25 15:04 LGUG2Z