LDflex-Comunica icon indicating copy to clipboard operation
LDflex-Comunica copied to clipboard

GraphQL code is unnecessarily included

Open RubenVerborgh opened this issue 5 years ago • 5 comments

Inspecting the generated package with webpack-bundle-analyzer, I noticed that GraphQL code was also included because that is required by @comunica/actor-init-sparql/engine-default.js. Would should probably have a learner config than that default.

RubenVerborgh avatar Nov 06 '19 22:11 RubenVerborgh

This probably won't be a quick-fix. We'll have to refactor stuff a bit for this (see https://github.com/comunica/comunica/issues/267)

rubensworks avatar Nov 08 '19 03:11 rubensworks

This probably won't be a quick-fix.

We can webpack them out for now.

Also the crypto stuff is very heavy; we can likely do with https://github.com/LinkedDataFragments/Client.js/blob/master/lib/browser/crypto.js

RubenVerborgh avatar Nov 08 '19 08:11 RubenVerborgh

Also the crypto stuff is very heavy

This is extensively being used by sparqlee. Since LDflex does not really makes use of filters at the moment, we could probably remove these from the configs as well. And then a more lightweight crypto implementation would be perfect indeed.

rubensworks avatar Nov 08 '19 21:11 rubensworks

This is extensively being used by sparqlee.

Also for hashing though.

RubenVerborgh avatar Nov 08 '19 21:11 RubenVerborgh

Also for hashing though.

Indeed. Only the distinct/reduced actors do hashing I think. But AFAIK LDflex doesn't use these either, so we can probably remove these from the config as well.

rubensworks avatar Nov 08 '19 21:11 rubensworks