LDMX-Software
Add TS light pipes to v15 geometry
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Check List
- [ ] I successfully compiled ldmx-sw with my developments.
- [ ] I read, understood and follow the coding rules.
- [ ] I ran my developments and the following shows that they are successful.
@Layan-Sarayra also as a general practice, please follow the steps in the checklist at the top of the PR, and check the items once you have completed them. adding (to the PR discussion) any plots or printouts you have that show why you think your work is solving the issue is super helpful for the review, and is a great way to document your work for posterity.
Do we know why the hcal validation test is failing? i'm not sure i understand the plots to boot (in gold), especially the TS simhit ones. the test is using a gun upstream of the ecal, isn't it? i
Yes, it's shooting neutrons upstream of the ECAL face (220 mm). But I dont understand why it fails, I could imagine possible overlaps to cause issues, but that should be there for all cases. Let's try to test again
changes in the hcal are unrelated, I see a big list of KS failing in https://github.com/LDMX-Software/ldmx-sw/actions/runs/19351298324/job/55364065010?pr=1874 and that PR really doenst change anything in the DQM plots
So funny HCAL passed all good now https://github.com/LDMX-Software/ldmx-sw/actions/runs/19352192552/job/55366685464?pr=1869