ldmx-sw icon indicating copy to clipboard operation
ldmx-sw copied to clipboard

Better handle filter thresholds (8 GeV vs 4 GeV)

Open tvami opened this issue 8 months ago • 1 comments

Is your feature request related to a problem? Please describe.

Right now we have moved a lot of things to 8 GeV, but the filter thresholds are behind many times, e.g. https://github.com/LDMX-Software/ldmx-sw/blob/trunk/Biasing/python/filters.py#L191 The user has to remember to change this at production, which leads to the situation like

Image

Describe the solution you'd like

I think we should rewrite these so they take the generator as input and then all the thresholds are the function of the beam energy, i.e. this needs to be changed once only.

Describe alternatives you've considered

Change the defaults

Additional context

Design report

tvami avatar Apr 18 '25 03:04 tvami

I ran into this with EaT and so you could see a potential solution in the eat.py module.

https://github.com/LDMX-Software/ldmx-sw/blob/trunk/Biasing/python/eat.py

Basically, a function that takes in the generator ensures that all the filters and biasing operators have their thresholds aligned with the generator energy. The function then returns the simulation processor to be included in the configuration.

tomeichlersmith avatar Apr 29 '25 14:04 tomeichlersmith