ldmx-sw icon indicating copy to clipboard operation
ldmx-sw copied to clipboard

Persist the actual simulated position of the ECAL hit rather than the cell center

Open tvami opened this issue 1 year ago • 1 comments

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Resolves https://github.com/LDMX-Software/ldmx-sw/issues/1484

But I'm only opening it as a draft first to see the effect using the CI tests

Check List

  • [x] I successfully compiled ldmx-sw with my developments
  • [ ] I ran my developments and the following shows that they are successful.

tvami avatar Oct 02 '24 21:10 tvami

OK I think it's worth doing this. I'll also address https://github.com/LDMX-Software/ldmx-sw/issues/1482 in this PR next

tvami avatar Oct 03 '24 02:10 tvami

I added the new plots: X Screenshot 2025-01-17 at 11 43 43

Y Screenshot 2025-01-17 at 11 44 08

Z Screenshot 2025-01-17 at 11 44 29

X/Y makes a lot of sense.

Z is what I believe is what's in https://github.com/LDMX-Software/ldmx-sw/issues/1490

tvami avatar Jan 17 '25 19:01 tvami

@tomeichlersmith what do you think about the Z? Should I have https://github.com/LDMX-Software/ldmx-sw/issues/1490 takled in this PR too? Or maybe just open another PR... but then I dont know what to do with the weights

tvami avatar Jan 17 '25 19:01 tvami

Or maybe just open another PR...

I think it's prob better to be in another PR provided that we dont have too much time in between the two PRs. Then I can easily compare these plots to show the changes

tvami avatar Jan 17 '25 19:01 tvami

In the spirit that we are about to fix the issue for Z in the branch iss1490 I zoomed in in the Z axis in https://github.com/LDMX-Software/ldmx-sw/pull/1485/commits/d7d49895b0732140fb83fe97f1a2d030b417dc29

tvami avatar Jan 18 '25 16:01 tvami