ldmx-sw
ldmx-sw copied to clipboard
Optimize ECAL lin-reg
Is your feature request related to a problem? Please describe.
This is a follow-up to https://github.com/LDMX-Software/ldmx-sw/pull/1407 There are several things to make the lin-reg better. List below.
Describe the solution you'd like
- Implement that we really are selecting hits from the closest hits
https://github.com/LDMX-Software/ldmx-sw/blob/e6c6935a7b0426d5302b270e2f10bc08737f33f9/Ecal/src/Ecal/EcalVetoProcessor.cxx#L996
and then
https://github.com/LDMX-Software/ldmx-sw/blob/e6c6935a7b0426d5302b270e2f10bc08737f33f9/Ecal/src/Ecal/EcalVetoProcessor.cxx#L1028
it should prob take the hits from
trackingHitList[hitsInRegion[jHit]]and alsotrackingHitList[hitsInRegion[kHit]]and propagate this below in the code too. - That opens up immediately that 50 in
int hitsInRegion[50];might be not realistic - And then the distance in https://github.com/LDMX-Software/ldmx-sw/blob/e6c6935a7b0426d5302b270e2f10bc08737f33f9/Ecal/src/Ecal/EcalVetoProcessor.cxx#L1018 was not optimized at all.
Besides the physics changes discussed above we could also consider to move away from the ROOT approach and use Eigen instead.
Describe alternatives you've considered
Keep it as it is, currently it's not really used, but I think it has potential.