ldmx-sw
ldmx-sw copied to clipboard
Rechit producer doesn't set module number
In the process of ntupling TS collections, I noticed that the functionality of propagating which pad we're on outside of collection names has fallen out in the RecHitProducer: it's simply set to 0 here
I think we should
- set it to default to -1 and not 0 (module numbers are 0,1,2 (for tag, up, down))
- set it such that a hit always carries the info on where it lives (noise or not, which was a bug in the old DigiProducer: it would not be set unless there were non-noise hits in a pad). This can be propagated to clusters, and then to tracks; this makes it easier to do track->hit association because in principle the info on in which pad a hit happened is otherwise lost (the track collection combines all pads).
@GNiramay @awhitbeck any thoughts about this?
Sorry, I was wrong. Module numbers are 1,2,3. Then taking 0 to mean uninitialized is fine. Or, we take this opportunity to change this to start counting at 0 as everyone would expect?