LCAV
Add AnechoicRoom class
This pull request reopens #160, now against the new version of pyroomacoustics.
This will close issue #13.
I am working on polishing it and will remove the "WIP" tag when done.
- [x] Are there docstrings ? Do they follow the numpydoc style ?
- [x] Have you run the tests by doing
nosetestsorpy.testat the root of the repo ? - [x] Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
- [x] Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
- [x] Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".
Hi @duembgen ! What is the status on this pull request ? If it is good, I could just pull it in. The tests are failing now, so maybe a merge or something is needed.
Hi @fakufaku thank you for your comments! I am finalizing the pull request now. Will remove the Eigen comment if it is fixed by doing a recursive clone. Do you have any preference on how / if to mention the AnechoicRoom class in the documentation? I added another section called Free-field simulation in the room doc file, but happy to change that.
Regarding the CHANGELOG, would you like me to be more specific than Added AnechoicRoom class?
sorry for bursting into your conversation: Just yesterday I created a script using the idea from issue #13 (max_order=0 for the room creation). I will try the new room as soon as it's ready and give you feedback!
@fakufaku I have simplified the example, I hope that's roughly what you had in mind. Feel free to change anything to your liking and merge as soon as you are satisfied. @EliasBrohammer sorry for the late reply.
@duembgen Sorry it took me so long to merge this! Thanks for your contribution!!! 🙏