activity-browser icon indicating copy to clipboard operation
activity-browser copied to clipboard

Fake ecoinvent parameters potentially creating issues

Open MaximeAgez opened this issue 1 year ago • 3 comments

Ecoinvent processes have "Formulas" for their biosphere flows which are chemical formulas and not formulas used to calculate an amount:

image

Because both are called "Formulas", I think AB interprets those chemical formulas as actual formulas used alongside parameters, which triggers some errors:

image

The import of database still operates properly, so it's not a AB-breaking bug, but it should still be fixed.

MaximeAgez avatar Aug 24 '22 18:08 MaximeAgez

@cmutel @bsteubing I agree that this should be fixed. BW accepts basically any named data for exchanges. At some point this may cause problems (e.g. when using a Parameter with a name that already exists as a chemical formula things may break).

As activities in BW don't really care about additional data in exchanges, would it be an idea to somehow detect ecoinvent databases and then put their chemical formula names into another column (e.g. Chemical Formula) could we do this with an import strategy or something? Another option would be to move the formulas system to another column, but this would likely break backwards compatibility right?

marc-vdm avatar Sep 22 '22 10:09 marc-vdm