ProjectLighthouse icon indicating copy to clipboard operation
ProjectLighthouse copied to clipboard

General concerns with code quality

Open sudokoko opened this issue 1 year ago • 4 comments

There are some concerns regarding uniformity of code quality throughout the project. This issue will serve as a discussion point for possible solutions and as a tracking point for related PRs.

sudokoko avatar Jan 19 '24 14:01 sudokoko

to quote slendy

"it's time for lighthouse 2"

anyway, what specific concerns do we have with the code quality?

m88youngling avatar Jan 19 '24 18:01 m88youngling

Generally, the code quality throughout the project is not uniform and uses a variety of styles. A good first step to resolve this could be to set up a CI linter for pull requests. We could decide on an optimal linter configuration through discussion, as well as maybe fine-tuning our DotSettings file, and have a passing linter be a requirement for PR merge.

sudokoko avatar Jan 19 '24 18:01 sudokoko

I'm assuming what that will effectively do is require certain styles and formats of the code and check for syntax automatically to make sure it's compliant?

m88youngling avatar Jan 19 '24 18:01 m88youngling

I'm assuming what that will effectively do is require certain styles and formats of the code and check for syntax automatically to make sure it's compliant?

Yes, that is what a linter does

sudokoko avatar Jan 19 '24 18:01 sudokoko