ProjectLighthouse icon indicating copy to clipboard operation
ProjectLighthouse copied to clipboard

Include CSS in the repository

Open TorutheRedFox opened this issue 3 years ago • 5 comments

The build currently doesn't include the necessary CSS for the website making you have to source it yourself.

TorutheRedFox avatar Aug 22 '22 16:08 TorutheRedFox

I have actually thought about this a bit, how much of the styling of the website should Lighthouse be bundled with? It's possible that instances could build their own custom closed source website and then use Lighthouse api as the base from which to operate the website from. But, for instances without a need for a fancy website, it may not be necessary for stock Lighthouse to come with a super advanced website with advanced CSS styling. However, I think you're right that basic CSS styling may be helpful.

m88youngling avatar Aug 22 '22 16:08 m88youngling

I have actually thought about this a bit, how much of the styling of the website should Lighthouse be bundled with? It's possible that instances could build their own custom closed source website and then use Lighthouse api as the base from which to operate the website from. But, for instances without a need for a fancy website, it may not be necessary for stock Lighthouse to come with a super advanced website with advanced CSS styling. However, I think you're right that basic CSS styling may be helpful.

from looking at and testing the code, it's a case of the actual base styles of the page have been replaced with local references to a file to be hosted by lighthouse rather than a reference to a CDN, I'm not sure why this was done but I'm sure there was a good reason for it. on a side note, the logo appears to be missing, even with the CSS put back. image

Zaprit avatar Aug 22 '22 21:08 Zaprit

Upon further investigation the files are there, the StaticFile parts are not working, at least on my local instance

Zaprit avatar Aug 23 '22 00:08 Zaprit

the logo is missing because it's two png files

TorutheRedFox avatar Aug 24 '22 11:08 TorutheRedFox

what should be included is example versions of semantic.min.css, styles.css, and the slot background and overlay images

TorutheRedFox avatar Aug 24 '22 11:08 TorutheRedFox

This is a configuration issue rather than a Project Lighthouse issue. Closing.

Slendy avatar Nov 06 '22 01:11 Slendy