beam icon indicating copy to clipboard operation
beam copied to clipboard

modalBehaviors.transitVehicleTypeVOTMultipliers does not behave as expected

Open wrashid opened this issue 1 year ago • 0 comments

somewhat related issue: In class PopulationAttributes.scala we only use this parameter, if used by a single mode, however, it could be generalized to multiple modes (not perfect, but better):

        val modeMultiplier = getModeVotMultiplier(Option(embodiedBeamLeg.beamLeg.mode), modeChoiceModel)
        val beamVehicleTypes = embodiedBeamTrip.beamLegs.map(_.mode).toSet.map(mode => TransitVehicleInitializer.transitModeToBeamVehicleType(mode))
        val vehicleTypeVOTMultipliers=beamVehicleTypes.map(beamVehicleTypeId=>modeChoiceModel.transitVehicleTypeVOTMultipliers.getOrElse(beamVehicleTypeId, modeMultiplier))
        val multiplier = vehicleTypeVOTMultipliers.sum / vehicleTypeVOTMultipliers.size

wrashid avatar Oct 05 '23 16:10 wrashid