Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

website: Refactor task page routes and repetition

Open rjmacarthy opened this issue 2 years ago • 3 comments

Hey,

Through careful refactoring, we were able to make the code more DRY (Don't Repeat Yourself) by creating a single, reusable component that dynamically renders the correct task based on the type passed to it. This not only streamlines the codebase but also ensures consistency across all routes. Additionally, we have fixed an error that previously caused the app to show a disabled button instead of a "no-tasks" interface #924. These improvements will lead to a smoother user experience and make the code easier to maintain.

If you have any questions or concerns please let me know.

rjmacarthy avatar Jan 26 '23 13:01 rjmacarthy

@rjmacarthy did you talk to @fozziethebeat on discord about this or was it discussed in an issue here on gh? In general it is better to first clarify with the code owner. I am no member of the web-team but if you make far reaching changes without prior discussion you risk that your work is lost because it never gets merged.

andreaskoepf avatar Jan 26 '23 13:01 andreaskoepf

@rjmacarthy did you talk to @fozziethebeat on discord about this or was it discussed in an issue here on gh? In general it is better to first clarify with the code owner. I am no member of the web-team but if you make far reaching changes without prior discussion you risk that your work is lost because it never gets merged.

Hey @andreaskoepf,

Thank you for bringing this to my attention. Apologies, I will make sure to reach out to @fozziethebeat and discuss any proposed changes with them before proceeding. I will also ensure that any discussions take place in the appropriate forum, such as a Discord channel or GitHub issue, to ensure that the changes align with the project's goals. My apologies for not following this process in the first place. It should be mentioned that the issue that was raised is now fixed and I hope that this can be taken into consideration when reviewing the changes. If you would prefer that I close this pull request in favour of the original code then please let me know.

Thank you!

rjmacarthy avatar Jan 26 '23 14:01 rjmacarthy

:x: pre-commit failed. Please run pre-commit run --all-files locally and commit the changes. Find more information in the repository's CONTRIBUTING.md

github-actions[bot] avatar Jan 27 '23 10:01 github-actions[bot]