Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Added code instructions notebook

Open GravermanDev opened this issue 2 years ago • 6 comments

Added a notebook to convert code into instructions on how to build that code. This model will be refined later but it is working failry well right now. This solves issue #297

GravermanDev avatar Jan 11 '23 14:01 GravermanDev

you should have just continued working in this PR instead, no? I dont think you needed to open a new PR as we could have iterated on the other one. Happy to help with any github stuff.

https://github.com/LAION-AI/Open-Assistant/pull/624

andrewm4894 avatar Jan 11 '23 14:01 andrewm4894

I accidentally close this PR, doesn't matter really @andrewm4894

GravermanDev avatar Jan 11 '23 14:01 GravermanDev

just adding my same comment from the other PR https://github.com/LAION-AI/Open-Assistant/pull/624#issuecomment-1378702463

andrewm4894 avatar Jan 11 '23 14:01 andrewm4894

@GravermanDev did you already address comments from #624 ?

@GravermanDev cool - cant wait to play with this :)

can you add it into the notebooks/ folder and try follow similar example like this one: https://github.com/GravermanDev/Open-Assistant/tree/main/notebooks/example

pip install looks good at top of notebook maybe just try and:

  • add open in colab button cell to the top.
  • submit the notebook as ran with output so people browsing the repo can easily just see outputs from each cell.
  • maybe change CodeInstructions.md to README.md so will render the readme automatically in github.

yk avatar Jan 15 '23 09:01 yk

@53jk1 please stop blanket-approving all PRs. if you have specific constructive comments for improvements, leave those, otherwise code owners are the ones reviewing

yk avatar Jan 29 '23 19:01 yk

I think this might need to be updated from upstream/master to be able to merge since a few things have since changed a little in the /notebooks folder.

andrewm4894 avatar Jan 30 '23 11:01 andrewm4894