Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Drag and drop should not be constrained to the handle only

Open AbdBarho opened this issue 2 years ago • 2 comments

In ranking tasks, drag and drop should not be constrained to the handle only, but should be the entire text element.

https://github.com/LAION-AI/Open-Assistant/blob/42deae20f29492759c2f9d11ec088d875b45d476/website/src/components/Sortable/SortableItem.tsx#L24-L33

AbdBarho avatar Jan 06 '23 09:01 AbdBarho

I suggest we make sure to keep the drag handle icon so that it is still clear than it can be dragged (and after this change will also be easy to use)

othrayte avatar Jan 06 '23 10:01 othrayte

Also this element is interacted with in the end-to-end tests so make sure to run npm run cypress:run or npm run cypress (from the /website folder, and with the website running at localhost:3000 ) to check that those still pass.

othrayte avatar Jan 06 '23 10:01 othrayte

This is now already implemented.

AbdBarho avatar Jan 15 '23 09:01 AbdBarho