Open-Assistant
Open-Assistant copied to clipboard
Factor out the dashboard page layout into a shared layout
Right now website/src/pages/dashboard includes a nice Sidebar with multiple menu options and then presents the select page's contents.
This is a great design that would be nice to use in other scenarios such as for an admin specific page which would have different sidebar options.
To do this I think we need to:
- [ ] Make
website/src/components/Dashboard/SideMenuit's own independent component that takes in a list of menu options as a property. - [ ] Factor out the layout code in
website/src/pages/dashboardinto a layout component inwebsite/src/components/SideMenuLayoutthat also takes in the list of menu options. - [ ] Create several concrete layouts:
GeneralSidebarLayoutandAdminSidebarLayout, and maybe others. - [ ] Use
GeneralSidebarLayoutinwebsite/src/pages/dashboard - [ ] Use
AdminSidebarLayoutin future admin pages but using a different color scheme and different sidebar options.
@fozziethebeat I think I could take this issue. Could you assign it to me? Self-assigning needs Github's Collaborator role i think...
Great!@ Yeah, the assigning part is a bit of a hassle. After the MVP we might want to have a group discussion about simplifying it.
Also, since this is quite a few changes, I'd request this be done in a couple PRs rather than one giant PR.
could this be closed?