Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Factor out the dashboard page layout into a shared layout

Open fozziethebeat opened this issue 2 years ago • 2 comments

Right now website/src/pages/dashboard includes a nice Sidebar with multiple menu options and then presents the select page's contents.

This is a great design that would be nice to use in other scenarios such as for an admin specific page which would have different sidebar options.

To do this I think we need to:

  • [ ] Make website/src/components/Dashboard/SideMenu it's own independent component that takes in a list of menu options as a property.
  • [ ] Factor out the layout code in website/src/pages/dashboard into a layout component in website/src/components/SideMenuLayout that also takes in the list of menu options.
  • [ ] Create several concrete layouts: GeneralSidebarLayout and AdminSidebarLayout, and maybe others.
  • [ ] Use GeneralSidebarLayout in website/src/pages/dashboard
  • [ ] Use AdminSidebarLayout in future admin pages but using a different color scheme and different sidebar options.

fozziethebeat avatar Jan 06 '23 05:01 fozziethebeat

@fozziethebeat I think I could take this issue. Could you assign it to me? Self-assigning needs Github's Collaborator role i think...

Klotske avatar Jan 06 '23 23:01 Klotske

Great!@ Yeah, the assigning part is a bit of a hassle. After the MVP we might want to have a group discussion about simplifying it.

Also, since this is quite a few changes, I'd request this be done in a couple PRs rather than one giant PR.

fozziethebeat avatar Jan 06 '23 23:01 fozziethebeat

could this be closed?

AbdBarho avatar Jan 08 '23 10:01 AbdBarho