Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Submitting tags on the website doesn't work due to the API route not existing

Open fozziethebeat opened this issue 2 years ago • 3 comments

When you go to a task and try to flag a message with one of the checkbox entries, nothing happens. Inspecting the network logs it's calling an API path (/api/v1/text_labels) that doesn't exist.

To fix this it requires:

  • [ ] Making a new web api route under website/src/pages/api/set_label.tsx
  • [ ] Update the component website/src/components/FlaggableElement.tsx to call this web API route
  • [ ] Implement the web API route to forward the tag content to the backend server using the API key

fozziethebeat avatar Jan 04 '23 11:01 fozziethebeat

I can take this up if it's free. please add me to the website channel as well.

melvinebenezer avatar Jan 04 '23 13:01 melvinebenezer

Does this look fine ?

Screenshot 2023-01-06 at 6 55 08 AM

  1. should this be updated in the prism db
  2. should I test it with the backend ? from code review perspective it looked ok

melvinebenezer avatar Jan 06 '23 01:01 melvinebenezer

blocked by https://github.com/LAION-AI/Open-Assistant/pull/449

melvinebenezer avatar Jan 07 '23 09:01 melvinebenezer

I think this is almost ready to be closed. The only remaining fix is a small UI tweak to make sure the popup closes after the submission completes. I can take that on.

Thank you @melvinebenezer

fozziethebeat avatar Jan 10 '23 03:01 fozziethebeat