Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Add message id to messages in conversation model (protocol.py)

Open andreaskoepf opened this issue 2 years ago • 3 comments

Users should be able to give feedback for messages of a conversation when they are displayed in the fontends, e.g. during tasks to add a reply or when completed work is displayed in a recent activity view or the bot log-channel. Currently only the text and a flag whether the message is a user or an assistant message are sent to the client.

Add either a message_id field directly or in a meta-data dict. Potentially adapt other models like the MessageTree also, e.g. move meta data into a sub field, potentially create a class for standard-meta data (like date, message-id, user-id, frontend-user, frontend-message-id).

-> Align potocol with data_schemas docs.

andreaskoepf avatar Jan 04 '23 07:01 andreaskoepf

use case e.g. see 2.) of https://github.com/LAION-AI/Open-Assistant/issues/231#issuecomment-1369768813

andreaskoepf avatar Jan 04 '23 07:01 andreaskoepf

Until we have a better solution, please include a message_id and a separate frontend_message_id field in ConversationMessage. @yk check

andreaskoepf avatar Jan 05 '23 18:01 andreaskoepf

https://github.com/LAION-AI/Open-Assistant/issues/371 is dependent on this fix.

melvinebenezer avatar Jan 07 '23 09:01 melvinebenezer