Open-Assistant icon indicating copy to clipboard operation
Open-Assistant copied to clipboard

Published 20 hours ago • verified publisher icon LAION-AI

Devcontainer improvements

Open andrewm4894 opened this issue 2 years ago • 2 comments

playing around with similar idea to this PR. https://github.com/LAION-AI/Open-Assistant/pull/327

changes:

  • make devcontainer more generic as opposed to launching into any specific service.
  • add readme to .devcontainer folder.
  • ensure pre-commit is installed and available in dev container.
  • validate that docker compose up --build works from within the codespace.

andrewm4894 avatar Jan 03 '23 15:01 andrewm4894

image

andrewm4894 avatar Jan 03 '23 16:01 andrewm4894

image

andrewm4894 avatar Jan 03 '23 16:01 andrewm4894

hey this is awesome. do you think you could also tell people about this in the main README? or at least drop a hint there with a link to the readme you wrote?

yk avatar Jan 03 '23 20:01 yk

hey this is awesome. do you think you could also tell people about this in the main README? or at least drop a hint there with a link to the readme you wrote?

yep will do, will add a one liner and link. just was hesitant to add too much myself into the main readme but agree makes sense to reference it - will do in a few mins

andrewm4894 avatar Jan 03 '23 20:01 andrewm4894

@yk done

andrewm4894 avatar Jan 03 '23 20:01 andrewm4894